Benchmarks fpu whetstone #3343
Benchmarks fpu whetstone #3343
Conversation
acassis
left a comment
acassis
left a comment
There was a problem hiding this comment.
@ThePassionate please add a Documentation about this new app.
raiden00pl
left a comment
raiden00pl
left a comment
There was a problem hiding this comment.
what is this licence? Is it even Apache compatible? we need to add license guard to this code
|
It's some kind of custom license, I think we should add "ALLOW_CUSTOM_COMPONENTS" or something like that for such strange cases |
Thanks! I have updated a README about testing module and how to test. |
I update Apache-2.0 License for Nuttx and add reference from source file |
|
@ThePassionate You can't relicense this file. This license doesn't appear to be compatible with Apache. EDIT: the license must remain as it was and the compilation must be guarded by Also nuttx doesn't use README anymore, please move this to nuttx/Documentation |
@ThePassionate we deprecated README files some years ago, all Documentation for nuttx and nuttx-apps should be created as ReStructuredText at nuttx/Documentation/ Please move it to there |
acassis
left a comment
acassis
left a comment
There was a problem hiding this comment.
@ThePassionate please create the Documentation file at https://nuttx.apache.org/docs/latest/applications/benchmarks/index.html
Thanks! I didn't know the document path was in the Nuttx repository. I was searching in the current directory and only wrote the README because I couldn't find a suitable path. Thank you for your patience！ |
so should I add this license KCONFIG in this patch? it looks good to me. |
I get it ! Let me try |
please review apache/nuttx#18017 @acassis @raiden00pl Thanks! |
|
@jerpelea seems like there is not an official SPDX definition for Whetstone benchmark, how can I suggest this license to them: SPDX-License-Identifier: LicenseRef-Painter-Engineering-Whetstone |
acassis
left a comment
acassis
left a comment
There was a problem hiding this comment.
@ThePassionate please remove README.md from PR
ThePassionate
force-pushed
the
benchmarks-fpu-whetstone
branch
from
dc74fc7 to
e2b3f3c
Compare
Add the Whetstone floating-point benchmark to NuttX applications. The Whetstone benchmark is a widely-used tool for evaluating FPU (floating-point unit) performance. This benchmark is ported from netlib.org whetstone.c which has a custom permissive license requiring attribution. Therefore it depends on ALLOW_CUSTOM_PERMISSIVE_COMPONENTS. Usage: whetstone [loops] Signed-off-by: makejian <[email protected]>
Change FPU benchmark timing from seconds to milliseconds for better accuracy. This allows for more precise measurement of test cycles, especially for shorter test runs that previously completed within a single second. Signed-off-by: makejian <[email protected]>
ThePassionate
force-pushed
the
benchmarks-fpu-whetstone
branch
from
e2b3f3c to
7bc83a5
Compare
Done. Thanks again! |
|
@ThePassionate please rebase your change |
4 participants
Benchmarks: Add Whetstone FPU Benchmark with Enhanced Timing
Summary
This PR adds the Whetstone floating-point benchmark to NuttX applications. The Whetstone benchmark is a widely-used tool for evaluating FPU (floating-point unit) performance. The implementation includes timing enhancements that provide millisecond-level precision for more accurate performance measurement.
Changes
Files Added
benchmarks/whetstone/CMakeLists.txt
benchmarks/whetstone/Kconfig
benchmarks/whetstone/Make.defs
benchmarks/whetstone/Makefile
benchmarks/whetstone/whetstone.c
Technical Details
Whetstone Benchmark:
Timing Precision Enhancement:
Benefits:
Impact
Usage
Enable benchmark with:
CONFIG_BENCHMARKS_WHETSTONE=y
Testing
Benchmark functionality verified on various systems with FPU support.
nsh> whetstone 100000 Loops: 100000, Iterations: 1, Duration: 5 sec.C Converted Double Precision Whetstones: 2.00 MWIPSAuthor: makejian [email protected]